Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create stream error response #502

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix create stream error response #502

merged 1 commit into from
Sep 14, 2023

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Sep 14, 2023

Fixes #487.

Description

Change status code based on error type

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht self-requested a review September 14, 2023 05:48
@nitisht nitisht merged commit dcc83e1 into parseablehq:main Sep 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
@trueleo trueleo deleted the refactor branch September 15, 2023 08:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitisht nitisht Awaiting requested review from nitisht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect error code in ingest when validation failed
2 participants
@trueleo @nitisht